Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Use nock@14, support node@20/fetch #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oliversalzburg
Copy link

The toStrictEqual calls had to be replaced, because it falsely assumed to receive back the exact same in-memory object, which seems like an unrealistic expectation in the test, that was only satisfied through the previous dependency implementation details.

Fixes #77

@shubhbapna
Copy link
Collaborator

Thank you for your PR! I am currently on vacation and will be back on 12th June

@shubhbapna shubhbapna self-requested a review June 19, 2024 15:01
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/report.yml Outdated Show resolved Hide resolved
.github/workflows/update.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 18 and @octokit/core v5.0.0 incompatability
2 participants