feat!: Use nock@14, support node@20/fetch #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! I am currently on vacation and will be back on 12th June |
shubhbapna
requested changes
Jun 19, 2024
shubhbapna
requested changes
Jun 28, 2024
oliversalzburg
force-pushed
the
feat/nock14
branch
from
9960853
to
cdd6902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toStrictEqualcalls had to be replaced, because it falsely assumed to receive back the exact same in-memory object, which seems like an unrealistic expectation in the test, that was only satisfied through the previous dependency implementation details.Fixes #77