PLANNER-297 Don't pollute the test log with a stacktrace

kiegroup · Jun 24, 2015 · 341cfb3 · 341cfb3
1 parent 8186761
commit 341cfb3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/...lanner-benchmark/src/main/java/org/optaplanner/benchmark/impl/PlannerBenchmarkRunner.java b/...lanner-benchmark/src/main/java/org/optaplanner/benchmark/impl/PlannerBenchmarkRunner.java
@@ -44,6 +44,8 @@
 public class PlannerBenchmarkRunner implements PlannerBenchmark {
 
     protected final transient Logger logger = LoggerFactory.getLogger(getClass());
+    protected final transient Logger singleBenchmarkRunnerExceptionLogger = LoggerFactory.getLogger(
+            getClass().getName() + ".singleBenchmarkRunnerException");
 
     private final PlannerBenchmarkResult plannerBenchmarkResult;
 
@@ -141,7 +143,8 @@ private void warmUp() {
         }
     }
 
-    protected long warmUp(ProblemBenchmarkResult problemBenchmarkResult, long startingTimeMillis, long warmUpTimeMillisSpentLimit, long timeLeft) {
+    protected long warmUp(ProblemBenchmarkResult problemBenchmarkResult,
+            long startingTimeMillis, long warmUpTimeMillisSpentLimit, long timeLeft) {
         for (SingleBenchmarkResult singleBenchmarkResult : problemBenchmarkResult.getSingleBenchmarkResultList()) {
             SolverBenchmarkResult solverBenchmarkResult = singleBenchmarkResult.getSolverBenchmarkResult();
             TerminationConfig originalTerminationConfig = solverBenchmarkResult.getSolverConfig().getTerminationConfig();
@@ -154,7 +157,8 @@ protected long warmUp(ProblemBenchmarkResult problemBenchmarkResult, long starti
                 Solver solver = solverBenchmarkResult.getSolverConfig().buildSolver();
                 solver.solve(problemBenchmarkResult.readPlanningProblem());
             } catch (RuntimeException e) {
-                logger.error("The warmUp of singleBenchmark (" + singleBenchmarkResult.getName() + ") failed.", e);
+                singleBenchmarkRunnerExceptionLogger.warn("The warmUp of singleBenchmark ("
+                        + singleBenchmarkResult.getName() + ") failed.", e);
                 // TODO update firstFailureSingleBenchmarkRunner (when warmups happen in a Runner too in parallel)
             }
 
@@ -195,11 +199,12 @@ protected void runSingleBenchmarks() {
                 failureThrowable = e;
             } catch (ExecutionException e) {
                 Throwable cause = e.getCause();
-                logger.error("The singleBenchmarkRunner (" + singleBenchmarkRunner.getName() + ") failed.", cause);
+                singleBenchmarkRunnerExceptionLogger.warn("The singleBenchmarkRunner ("
+                        + singleBenchmarkRunner.getName() + ") failed.", cause);
                 failureThrowable = cause;
             } catch (IllegalStateException e) {
                 // TODO WORKAROUND Remove when PLANNER-46 is fixed.
-                logger.error("The singleBenchmarkRunner (" + singleBenchmarkRunner.getName() + ") failed.", e);
+                singleBenchmarkRunnerExceptionLogger.warn("The singleBenchmarkRunner (" + singleBenchmarkRunner.getName() + ") failed.", e);
                 failureThrowable = e;
             }
             if (failureThrowable == null) {

diff --git a/optaplanner-examples/src/test/resources/logback-test.xml b/optaplanner-examples/src/test/resources/logback-test.xml
@@ -10,6 +10,8 @@
   </appender>
 
   <logger name="org.optaplanner" level="info"/>
+  <!-- Don't pollute the test log with a stacktrace -->
+  <logger name="org.optaplanner.benchmark.impl.PlannerBenchmarkRunner.singleBenchmarkRunnerException" level="error"/>
 
   <root level="warn">
     <appender-ref ref="consoleAppender" />