PLANNER-1394 Better error message than ArrayIndexOutOfBoundsException…

… due to difference Bendable score levels in benchmarker
kiegroup · Jan 25, 2019 · 7629910 · 7629910
1 parent eaabfdc
commit 7629910
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/...benchmark/src/main/java/org/optaplanner/benchmark/impl/result/PlannerBenchmarkResult.java b/...benchmark/src/main/java/org/optaplanner/benchmark/impl/result/PlannerBenchmarkResult.java
@@ -239,6 +239,10 @@ public int getMaximumSubSingleCount() {
 
     public String findScoreLevelLabel(int scoreLevel) {
         String[] levelLabels = solverBenchmarkResultList.get(0).getScoreDefinition().getLevelLabels();
+        if (scoreLevel >= levelLabels.length) {
+            // Occurs when mixing multiple examples in the same benchmark run, such as GeneralOptaPlannerBenchmarkApp
+            return "Unknown-" + (scoreLevel - levelLabels.length);
+        }
         return levelLabels[scoreLevel];
     }
 

diff --git a/...benchmark/src/main/java/org/optaplanner/benchmark/impl/result/ProblemBenchmarkResult.java b/...benchmark/src/main/java/org/optaplanner/benchmark/impl/result/ProblemBenchmarkResult.java
@@ -43,8 +43,10 @@
 import org.optaplanner.benchmark.impl.report.ReportHelper;
 import org.optaplanner.benchmark.impl.statistic.ProblemStatistic;
 import org.optaplanner.benchmark.impl.statistic.PureSubSingleStatistic;
+import org.optaplanner.core.api.domain.solution.PlanningScore;
 import org.optaplanner.core.api.solver.Solver;
 import org.optaplanner.core.config.util.ConfigUtils;
+import org.optaplanner.core.impl.score.definition.ScoreDefinition;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -196,7 +198,13 @@ public String getAnchorId() {
     }
 
     public String findScoreLevelLabel(int scoreLevel) {
-        String[] levelLabels = singleBenchmarkResultList.get(0).getSolverBenchmarkResult().getScoreDefinition().getLevelLabels();
+        ScoreDefinition scoreDefinition = singleBenchmarkResultList.get(0).getSolverBenchmarkResult().getScoreDefinition();
+        String[] levelLabels = scoreDefinition.getLevelLabels();
+        if (scoreLevel >= levelLabels.length) {
+            throw new IllegalArgumentException("The scoreLevel (" + scoreLevel
+                    + ") isn't lower than the scoreLevelsSize (" + scoreDefinition.getLevelsSize()
+                    + ") implied by the @" + PlanningScore.class.getSimpleName() + " on the planning solution class.");
+        }
         return levelLabels[scoreLevel];
     }