Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add code coverage for phase lifecycle and fix a few bugs (#194)
* Add phase lifecycle test & fix wrong solvingStarted() calls * Solving started/ended is now called only once per solve() execution * Fix DefaultSolver#removePhaseLifecycleListener(listener)
- Loading branch information
Showing
6 changed files
with
97 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
optaplanner-core/src/test/java/org/optaplanner/core/impl/phase/PhaseLifecyleTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Copyright 2016 Red Hat, Inc. and/or its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.optaplanner.core.impl.phase; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
|
|
||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.Mockito; | ||
| import org.mockito.runners.MockitoJUnitRunner; | ||
| import org.optaplanner.core.api.solver.Solver; | ||
| import org.optaplanner.core.api.solver.SolverFactory; | ||
| import org.optaplanner.core.impl.phase.event.PhaseLifecycleListener; | ||
| import org.optaplanner.core.impl.solver.DefaultSolver; | ||
| import org.optaplanner.core.impl.testdata.domain.TestdataEntity; | ||
| import org.optaplanner.core.impl.testdata.domain.TestdataSolution; | ||
| import org.optaplanner.core.impl.testdata.domain.TestdataValue; | ||
| import org.optaplanner.core.impl.testdata.util.PlannerAssert; | ||
| import org.optaplanner.core.impl.testdata.util.PlannerTestUtils; | ||
|
|
||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class PhaseLifecyleTest { | ||
|
|
||
| @Mock | ||
| private PhaseLifecycleListener<TestdataSolution> listener; | ||
|
|
||
| @Test | ||
| public void verifyEventCounts() { | ||
| // prepare solver | ||
| SolverFactory<TestdataSolution> solverFactory = PlannerTestUtils.buildSolverFactory( | ||
| TestdataSolution.class, TestdataEntity.class); | ||
| Solver<TestdataSolution> solver = solverFactory.buildSolver(); | ||
|
|
||
| // prepare solution | ||
| TestdataSolution solution = new TestdataSolution("s1"); | ||
| solution.setValueList(Arrays.asList(new TestdataValue("v1"), new TestdataValue("v1"))); | ||
| final int entitiesCount = 17; | ||
| ArrayList<TestdataEntity> entities = new ArrayList<>(entitiesCount); | ||
| for (int i = 0; i < entitiesCount; i++) { | ||
| entities.add(new TestdataEntity(String.valueOf(i))); | ||
| } | ||
| solution.setEntityList(entities); | ||
|
|
||
| // add listener mock and solve | ||
| ((DefaultSolver<TestdataSolution>) solver).addPhaseLifecycleListener(listener); | ||
| TestdataSolution solvedSolution = solver.solve(solution); | ||
|
|
||
| // step count = number of uninitialized entities (CH) + LS step count limit | ||
| final int stepCount = entitiesCount + PlannerTestUtils.TERMINATION_STEP_COUNT_LIMIT; | ||
| final int phaseCount = solverFactory.getSolverConfig().getPhaseConfigList().size(); | ||
| final int solvingCount = 1; | ||
| PlannerAssert.verifyPhaseLifecycle(listener, solvingCount, phaseCount, stepCount); | ||
|
|
||
| // forget previous invocations | ||
| Mockito.<PhaseLifecycleListener<?>>reset(listener); | ||
|
|
||
| // uninitialize 1 entity and solve again | ||
| solvedSolution.getEntityList().get(0).setValue(null); | ||
| solver.solve(solvedSolution); | ||
| PlannerAssert.verifyPhaseLifecycle(listener, solvingCount, phaseCount, 1 + PlannerTestUtils.TERMINATION_STEP_COUNT_LIMIT); | ||
|
|
||
| // forget previous invocations | ||
| Mockito.<PhaseLifecycleListener<?>>reset(listener); | ||
|
|
||
| // remove listener and solve again | ||
| ((DefaultSolver<TestdataSolution>) solver).removePhaseLifecycleListener(listener); | ||
| solver.solve(solution); | ||
| PlannerAssert.verifyPhaseLifecycle(listener, 0, 0, 0); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters