Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #12

Merged
merged 3 commits into from Oct 8, 2021
Merged

WIP #12

merged 3 commits into from Oct 8, 2021

Conversation

gusmccallum
Copy link
Contributor

Working on readConfig function and main logic

@gusmccallum gusmccallum marked this pull request as ready for review October 8, 2021 04:10
@kiennguyenchi
Copy link
Owner

You have changed the structure of the program by somehow I'm unable to test the old command arguments version. When I tested the program with --help or --version. After display the help menu or version text, it also displays "Empty config file. Please try again." at the end, which should not happen at all. It doesn't generate file with --input option.

I recommend you to divide the code in main into if-else, if it is not config file, going to the previous direction which check for command line arguments. If it is config file, ignore all the command line arguments.

Also, I haven't seen any supports for lang or stylesheet. You can retrieve the lang and stylesheet values in the main function. For lang, you can initialize lang variable in the constructor of an HTMLFile object. Also, you can add an attribute of stylesheet to this class HTMLFile.

Thank you!

@kiennguyenchi kiennguyenchi merged commit 8ec2a64 into kiennguyenchi:main Oct 8, 2021
@github-pages github-pages bot temporarily deployed to github-pages October 8, 2021 21:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants