Skip to content

Commit

Permalink
Replacing ALE LSP with LanguageClient-neovim.
Browse files Browse the repository at this point in the history
  • Loading branch information
Kieran Bamforth committed Jan 13, 2019
1 parent e0c4b62 commit 7b695e6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 76 deletions.
38 changes: 0 additions & 38 deletions .vim/bundle/vim-kieran/after/plugin/ale/jstsls.vim
View file

This file was deleted.

38 changes: 0 additions & 38 deletions .vim/bundle/vim-kieran/after/plugin/ale/pyls2.vim
View file

This file was deleted.

8 changes: 8 additions & 0 deletions .vimrc
View file
Expand Up @@ -5,6 +5,7 @@ call plug#begin('~/.vim/bundle')
Plug '/usr/local/opt/fzf'
Plug 'SirVer/ultisnips'
Plug 'airblade/vim-gitgutter'
Plug 'autozimu/LanguageClient-neovim', { 'branch': 'next', 'do': 'bash install.sh' }
Plug 'chrisbra/Colorizer'
Plug 'christoomey/vim-tmux-navigator'
Plug 'direnv/direnv.vim'
Expand Down Expand Up @@ -404,4 +405,11 @@ let g:gitgutter_sign_removed = emoji#for('fire')

" Dash
let g:dash_map = { 'yaml': ['cloudformation'] }

" Language Client
let g:LanguageClient_serverCommands = {
\ 'javascript': ['tcp://127.0.0.1:2089'],
\ 'javascript.jsx': ['tcp://127.0.0.1:2089'],
\ 'python': ['tcp://127.0.0.1:2090']
\}
" }}}

3 comments on commit 7b695e6

@sloria
Copy link

@sloria sloria commented on 7b695e6 Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: why did you end up switching from ALE to LanguageClient-neovim for LSP support?

@kieran-ohara
Copy link
Owner

@kieran-ohara kieran-ohara commented on 7b695e6 Feb 7, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question- I found ALE to be kinda slow compared to LanguageClient. Iirc LanguageClient hands of to a rust binary which appears to be faster than vinscript

@sloria
Copy link

@sloria sloria commented on 7b695e6 Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see; thanks. I haven't run into sluggishness with ALE yet, though I've only starting using its LSP functionality. I quite like its ease of installation and Do The Right Thing approach. If I do run into performance issues, it's good to know there's an alternative.

Please sign in to comment.