Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit C++ code for safety #2

Open
kieraneglin opened this issue Feb 18, 2021 · 0 comments
Open

Audit C++ code for safety #2

kieraneglin opened this issue Feb 18, 2021 · 0 comments
Labels
C++ help wanted Extra attention is needed

Comments

@kieraneglin
Copy link
Owner

Related to and blocked by #1

As it stands, I lack the knowledge to gauge the safety of the C++ NIF code. Since a bad NIF can crash the entire Erlang VM, I could use a set of eyes on the C++ code to ensure best practices are followed. A list of (non-exhaustive) issues that come to mind:

  • How should instance destruction be handled?
  • Are the listener-related methods for MIDI input safe? Is the Erlang env being created and freed appropriately?
  • Is the way strings are being handled okay? Mainly around parsing the name of the instance passed from Elixir.

There are many more issues I'm sure but this is what comes to mind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kieraneglin