forked from fesh0r/b-em
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added PAGE DOWN to toggle pause emulation Added ARROW RIGHT to step a frame whilst paused
- Loading branch information
Showing
1 changed file
with
7 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7adb94f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, apart from the broken indentation and commented out code. Can you fix this, please?
7adb94f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet the indentation looked fine in Visual Studio. Unfortunately some of B-Em's code doesn't seem to look consistent across different editors, probably from mixing spaces and tabs.
For a change I am going to be the one to suggest taking a step back rather than rushing to merge because I have a suspicion the original pause feature is Windows-only and I'd like to see if we can make it work for both. But I have a Christmas meal to go to so it will have to be later on.
But it is a good idea, and one way or another, should make it into the Stardot B-Em.
7adb94f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I refer this back to stardot/b-em#34, please, because I want to propose something very similar but not quite the same which will work on Linux too.