Fix crash on rotate on very small angle #1080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe way to get first element in array
justinseanmartin
added a commit
to justinseanmartin/KIF
that referenced
this pull request
Aug 2, 2018
Add some generics to the arrays to make it a bit more clear Enforce that we always send at least 2 points for the path in 'twoFingerRotateAtPoint:angle:'. Add more safety in 'dragPointsAlongPaths:'.
justinseanmartin
added a commit
to justinseanmartin/KIF
that referenced
this pull request
Aug 2, 2018
Add some generics to the arrays to make it a bit more clear Enforce that we always send at least 2 points for the path in 'twoFingerRotateAtPoint:angle:'. Add more safety in 'dragPointsAlongPaths:'.
|
Thank you for identifying and root causing the issue! I've picked up your change into another branch and I'll include your commit along with my changes in #1081. Please take a look. Thanks! |
justinseanmartin
added a commit
to justinseanmartin/KIF
that referenced
this pull request
Aug 3, 2018
Add some generics to the arrays to make it a bit more clear Enforce that we always send at least 2 points for the path in 'twoFingerRotateAtPoint:angle:'. Add more safety in 'dragPointsAlongPaths:'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on rotation on very small angle.
AS IS
Crash on
view.twoFingerRotate(at: CGPoint(x: 0, y: 0), angle: angle)when angle = 0.01IN RESULT
No crash