Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tapping alert view buttons on iPads #213

Closed
wants to merge 1 commit into from
Closed

Fix for tapping alert view buttons on iPads #213

wants to merge 1 commit into from

Conversation

percysnoodle
Copy link
Contributor

On iPads, alert views are inside a _UIAlertNormalizingOverlayWindow whose coordinate space is not the same as that of elements' accessibilityFrames. This commit converts the accessibility frame into the main window's coordinate space instead, allowing alert view buttons to be tapped on iPads.

Also fixed is a bug whereby a tap step would seem to succeed if tappablePointInRect: returns (NAN, NAN), which is what currently happens on iPads, even though the element is never tapped.

@percysnoodle
Copy link
Contributor Author

I've updated this to work with the latest master.

@bnickel
Copy link
Contributor

bnickel commented Sep 9, 2013

I have not seen alert views fail on iPads with the KIF 2.0 test suite. Could you provide a failing project or failing tests?

@bnickel
Copy link
Contributor

bnickel commented Sep 16, 2013

This issue was resolved with a different (but similar) approach from issue #60. This approach uses the current window's coordinate space unless is has a transform applied to it. If it does, we then search the available windows for the first one with no transform applied to it.

@bnickel bnickel closed this Sep 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants