Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture named screenshot #287

Closed
wants to merge 3 commits into from

Conversation

phatmann
Copy link
Contributor

@phatmann phatmann commented Nov 4, 2013

When capturing screenshots manually you may not want the line number and source file in the screenshot name. This commit adds this functionality. It places the screenshots in subfolders based on device and system version used and appends device orientation to name, so runs on different device, OSes and orientations don't clobber each others screenshots.

@bnickel
Copy link
Contributor

bnickel commented Dec 19, 2013

A problem I'm having is that from name, I can't tell the functional difference between captureScreenshotWithDescription: and captureScreenshotNamed:.

Inside, the first is:

{filename}, line {line}, {description}

The second is:

{name} ({orientation}) {idiom}-{version}

A lot of the information from the second I would want to include in the first. I would rather see captureScreenshotWithDescription: enriched, producing:

{idiom}-iOS{version}/{filename}, line {line}, {description} ({orientation})

@phatmann
Copy link
Contributor Author

I would be happy to "enrich" captureScreenshotWithDescription as you suggest now that I know you approve of this approach. I will add this change to the pull request asap.

@phatmann
Copy link
Contributor Author

phatmann commented Jan 7, 2014

@bnickel, I made the changes you requested. Let me know if this pull request is acceptable now.

@phatmann
Copy link
Contributor Author

phatmann commented Mar 3, 2014

@bnickel what is the status of this pull request?

@newborntju
Copy link

could you tell me how to use it(for example) in testCase, i do not know how to use it in my project,thks

@phatmann
Copy link
Contributor Author

phatmann commented Jul 8, 2014

I am going to close this pull request, because there are better ways of doing screenshot compares. See LELA or ios-snapshot-test-case.

@phatmann phatmann closed this Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants