Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError: The number of driving images should be larger than the number of source images. #120

Closed
O-O1024 opened this issue Aug 6, 2024 · 2 comments

Comments

@O-O1024
Copy link

O-O1024 commented Aug 6, 2024

If the frame count of driving video is less than frame_load_cap,

image

this error will be raised:

Traceback (most recent call last):
  File "/root/ComfyUI/execution.py", line 151, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
  File "/root/ComfyUI/execution.py", line 81, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
  File "/root/ComfyUI/execution.py", line 74, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
  File "/root/ComfyUI/custom_nodes/ComfyUI-LivePortraitKJ/nodes.py", line 317, in process
    raise ValueError("The number of driving images should be larger than the number of source images.")
ValueError: The number of driving images should be larger than the number of source images.

😳 Is it necessary ? Why don't choose the same strategy like the official repo the 3th point ?

@kijai
Copy link
Owner

kijai commented Aug 6, 2024

Rude? I find it the opposite, rude would be to assume the user knows of this limitation and leave them wondering why is it not working. You can easily limit the frame load cap of the source as well with that same value.

@O-O1024
Copy link
Author

O-O1024 commented Aug 6, 2024

En en, yes. But I don't know how many frames the video contains before runing workflows to get this info, and VideoHelperSuit node doesn't provider it. @Kosinkadink

@O-O1024 O-O1024 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants