Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conda support #27

Open
Greedquest opened this issue Dec 17, 2021 · 2 comments
Open

Add Conda support #27

Greedquest opened this issue Dec 17, 2021 · 2 comments

Comments

@Greedquest
Copy link

This fantastic extension just blows https://github.com/dpranke/pyjson5 out of the water in terms of performance (as in 3 orders of magnitude for loads), which probably makes sense given it is cython :)

However unlike that library, this is only installable via pip, not conda as well. Would you be able to add conda support?

@Kijewski
Copy link
Owner

I never used conda, and I don't know anything about it, sorry. But I'd be happy to accept your PR if you know how to add conda support. :)

@Greedquest
Copy link
Author

Greedquest commented Dec 19, 2021

I've know roughly the process. I know the first step is to create both a build dist and a source dist. This can be done by running python setup.py sdist. For example your repo contains https://pypi.org/project/pyjson5/#files only wheels whereas the other json5 library that is conda compatible contains https://pypi.org/project/json5/#files both wheels and source files in tar.gz format. It also recommends including the README in MANIFEST.in

If you are able to get a source dist up on pypi then I can look through the next steps and make a PR sure, but I can't do anything till then I don't think. Sorry, don't want to add to your workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants