-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: this.queue.push is not a function #61
Comments
@pahund I was going through the code and I spotted that the I can open a PR to fix that, though I'm not sure how to replicate it consistently. |
That's a great catch, please do open a PR!
Not yet. We could set up a Storybook story where we set up and tear down at the click of a button, then write a Cypress test. But for now, it will suffice if you change these blatantly wrong curly braces into square brackets. |
Advertising queue is constructed as an array but when unmounting it is set to an object. Fixes #61 (comment)
Advertising queue is constructed as an array but when unmounting it is set to an object. Fixes #61 (comment)
In eBay's Track.js error tracking system for Kijiji Autos, we see reports like this:
These are errors happening in production, in our users' browsers.
Version 4.0.0.beta has improved the situation, so that the errors happen less frequently:
Stack trace:
The likely culprit is the de-initialization that happens when the
AdvertisingProvider
unmounts.The text was updated successfully, but these errors were encountered: