forked from buefy/buefy
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(lib): sort icons on Table overlapped next columns
- Fixes the issue that sort icons on Table overlapped or were clipped by next columns. Since sort icons were absolutely positioned and placed at the right side of the column label texts, the icons overlapped or were clipped by the right columns when columns were packed. This commit changes the anchor element for sort icons to `<div class="th-wrap">` elements that wrap the column label texts and absolutely places sort icons ON the right end of the `<div class="th-wrap">` elements instead. If the column `is-numeric`, the sort icon is placed on the left end of the `<div class="th-wrap">` element, otherwise the sort icon overlaps the column label text. Similar problems occurred when the `sort-multiple` option was turned on. Applying the above solution to the delete buttons of sort indicators did not work well. The delete buttons were torn apart from the sort icons since the sort icons aligned with the normal flow of the column label texts. I decided to group the sort icon, number, and delete button as `multi-sort-icons` so that they do not split. `multi-sort-icons` is placed in the normal flow of the column label texts and moves to the next line if the column is packed. issues - buefy#2886 - buefy#3034
- Loading branch information
Showing
2 changed files
with
37 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters