Skip to content

Commit

Permalink
fix(lib): remove unexpected tabindex (#9)
Browse files Browse the repository at this point in the history
- Fixes the bug that `Table` ended up with `<table>` with an unexpected
  "tabindex" attribute. This bug was caused because Vue 3 no longer
  removes a boolean attribute if its value is "false". `Table` binds
  `undefined` instead of `false` to "tabindex" if `focusable` is `false`
  or not specified.

issue ntohq#8
  • Loading branch information
kikuomax committed Jul 24, 2023
1 parent a7923de commit 81ca7cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/table/Table.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<table
class="table"
:class="tableClasses"
:tabindex="!focusable ? false : 0"
:tabindex="!focusable ? undefined : 0"
@keydown.self.prevent.up="pressedArrow(-1)"
@keydown.self.prevent.down="pressedArrow(1)"
>
Expand Down

0 comments on commit 81ca7cc

Please sign in to comment.