Skip to content

Commit

Permalink
Update main from dev And Publish @ntohq/buefy-next to NPM (buefy#12)
Browse files Browse the repository at this point in the history
* fix(lib): b-field-body wrapped text in b-field

- Fixes the bug that a horizontal `b-field-body` wrapped a simple text
  element with an extra `b-field`. It now returns a text element as is.

issue ntohq#5

* fix(lib): performance warning on FieldBody

- Removes a Vue runtime warning that indicated a potential performance
  issue related to how `FieldBody` gave the default slot to `Field`.
  Changes the third parameter of `h` function call to create a `Field`
  from a direct child `[element]` to a function slot `() => element`.

  This will address the issue pointed at in the comment:
  ntohq#1 (comment)

* fix(lib): remove unexpected tabindex (#9)

- Fixes the bug that `Table` ended up with `<table>` with an unexpected
  "tabindex" attribute. This bug was caused because Vue 3 no longer
  removes a boolean attribute if its value is "false". `Table` binds
  `undefined` instead of `false` to "tabindex" if `focusable` is `false`
  or not specified.

issue ntohq#8

* Publish Package @ntohq/buefy-next (#10)

* Removed CircleCi

* Created GitHub Action Workflow Files

* Added Workflow and Updated Package.json

* Update package.json (buefy#11)

* Update Package Name to `@ntohq/buefy-next` For Publishing to NPM (buefy#13)

* Update package.json

* Rename Package For Publishing to NPM

* Rename Package For Publishing to NPM

* Cleaned Up Workflow and Package.json

* Update package.json

---------

Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
  • Loading branch information
wesdevpro and kikuomax committed Jul 25, 2023
1 parent 67ecf3a commit a3c3ec5
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 60 deletions.
48 changes: 0 additions & 48 deletions .circleci/config.yml

This file was deleted.

3 changes: 0 additions & 3 deletions .github/FUNDING.yml

This file was deleted.

23 changes: 23 additions & 0 deletions .github/workflow/npm_deploy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Publish buefy-next to NPM
on:
push:
branches:
- main
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
steps:
- uses: actions/checkout@v3
# Setup .npmrc file to publish to GitHub Packages
- uses: actions/setup-node@v3
with:
node-version: '16.x'
registry-url: 'https://registry.npmjs.org/'
scope: '@ntohq'
- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Empty file.
14 changes: 9 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
{
"name": "buefy",
"version": "0.9.23",
"name": "@ntohq/buefy-next",
"version": "0.1.0",
"homepage": "https://buefy.org",
"description": "Lightweight UI components for Vue.js (v3) based on Bulma",
"author": "Rafael Beraldo <rafael.pimpa@gmail.com>",
"maintainers": [
"Walter Tommasi <tommsi20@gmail.com>",
"Kikuo Emoto <kemoto@codemonger.io>"
"Kikuo Emoto <kemoto@codemonger.io>",
"Wesley Ford <wes@wesdevpro.com>"
],
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
"license": "MIT",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
Expand All @@ -24,10 +28,10 @@
],
"repository": {
"type": "git",
"url": "https://github.com/buefy/buefy.git"
"url": "https://github.com/ntohq/buefy-next"
},
"bugs": {
"url": "https://github.com/buefy/buefy/issues"
"url": "https://github.com/ntohq/buefy-next/issues"
},
"vetur": {
"tags": "dist/vetur/tags.json",
Expand Down
6 changes: 3 additions & 3 deletions src/components/field/FieldBody.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script>
import { Comment, Fragment, h as createElement, resolveComponent } from 'vue'
import { Comment, Fragment, Text, h as createElement, resolveComponent } from 'vue'
export default {
name: 'BFieldBody',
Expand All @@ -26,7 +26,7 @@ export default {
default: () => {
return children.map((element) => {
// skip returns(?) and comments
if (element.type === Comment) {
if (element.type === Comment || element.type === Text) {
return element
}
let message
Expand All @@ -40,7 +40,7 @@ export default {
type: this.type,
message
},
[element]
() => element
)
})
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/table/Table.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<table
class="table"
:class="tableClasses"
:tabindex="!focusable ? false : 0"
:tabindex="!focusable ? undefined : 0"
@keydown.self.prevent.up="pressedArrow(-1)"
@keydown.self.prevent.down="pressedArrow(1)"
>
Expand Down

0 comments on commit a3c3ec5

Please sign in to comment.