-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem when removing first element of the list #1
Comments
@siggiorn thanks for reporting this, I am off duty for the next 3 weeks but I will try to look into this ASAP. If you want / can please submit a PR with a failing test suite, that would be super helpful |
@kilianc no problem, just created that PR |
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 17, 2016
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 17, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 17, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 18, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count Fix double registration for 'data' event. Combine common response handling code between RiakConnection and RiakNode Smal fix, event debugging comment added to RiakConnection
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 18, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count Fix double registration for 'data' event. Combine common response handling code between RiakConnection and RiakNode Smal fix, event debugging comment added to RiakConnection
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 18, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count Fix double registration for 'data' event. Combine common response handling code between RiakConnection and RiakNode Smal fix, event debugging comment added to RiakConnection
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Mar 18, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count Fix double registration for 'data' event. Combine common response handling code between RiakConnection and RiakNode Smal fix, event debugging comment added to RiakConnection re-register for events after setting up TLS connection
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Apr 9, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count Fix double registration for 'data' event. Combine common response handling code between RiakConnection and RiakNode Smal fix, event debugging comment added to RiakConnection re-register for events after setting up TLS connection Prepare to merge PR #145
lukebakken
pushed a commit
to basho/riak-nodejs-client
that referenced
this issue
Apr 10, 2016
Modify RiakConnection so that health check command is executed the same way as other commands. Implement socket timeout, default of 5 seconds. Ensure correct events are raised on timeout. Fix issues in socket timeout, improve logging Add RiakCluster test to demonstrate handling of read timeouts. Make data buffer private in RiakConnection Make expiration routine private in RiakNode add backoff to shutdown Remove use of linkedlist module due to this bug: kilianc/node-linkedlist#1 Standardize on "health check" verbiage in logging, improve RiakNode state management, make _stateCheck functions protected clarify debug log message Fix connection count Fix double registration for 'data' event. Combine common response handling code between RiakConnection and RiakNode Smal fix, event debugging comment added to RiakConnection re-register for events after setting up TLS connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey guys, I think I've observed incorrect behavior when removing the first element from the list:
I simply create the list with the strings 0, 1, 2, 3
Now I iterate through the list and demonstrate that removing an element that isn't first works fine
console.log("\nExpect 0, 1, 2, 3");
We see the following output
0, 1, 2, 3
and expect that the list now contains the strings 0, 2, 3If we now iterate through the list again but this time remove the first element we get something unexpected:
Here we see
0, 3
but we expected0, 2, 3
The text was updated successfully, but these errors were encountered: