Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Location as KarteLocation #28

Closed
josselin-oudry opened this issue May 29, 2019 · 3 comments
Closed

Rename Location as KarteLocation #28

josselin-oudry opened this issue May 29, 2019 · 3 comments

Comments

@josselin-oudry
Copy link

Hi there,

Thanks for making this great library. I was wondering though whether you could rename public struct Location {} into public struct KarteLocation {}. We are using a custom Location class in our code and using Karte creates a naming collision with this class.

Thanks in advance.

@kiliankoe
Copy link
Owner

Argh, I thought Swift's namespacing should take care of this, but it seems the type Karte overrides the namespace making this impossible.

@kiliankoe
Copy link
Owner

I just pushed version 3.0.0 that renames this as you proposed. Thanks for the heads up!

@josselin-oudry
Copy link
Author

Awesome! Thanks for responding and making the change so quickly.

@fluidsonic fluidsonic mentioned this issue May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants