-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename App #29
Comments
I like the idea of moving the questionable named types into |
fixed with 8cded89 |
I just pushed version 4.0.0 with your suggested changes, thanks again 😊 |
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for the nice library!
Unfortunately just like #28 the name
App
is way too generic and causes an unresolvable collision for us.Either
App
should be renamed toKarteApp
/NavigationApp
/ … orpublic enum Karte
should be renamed to something different from the module so that any kind of conflict can be resolved e.g. by usingKarte.App
.Or maybe nest
App
andLocation
etc inside theKarte
enum so that everything must always be qualified (Karte.Location
,Karte.App
etc.)The text was updated successfully, but these errors were encountered: