Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename App #29

Closed
fluidsonic opened this issue May 31, 2019 · 4 comments
Closed

Rename App #29

fluidsonic opened this issue May 31, 2019 · 4 comments

Comments

@fluidsonic
Copy link

Thanks for the nice library!

Unfortunately just like #28 the name App is way too generic and causes an unresolvable collision for us.

Either App should be renamed to KarteApp / NavigationApp / … or public enum Karte should be renamed to something different from the module so that any kind of conflict can be resolved e.g. by using Karte.App.

Or maybe nest App and Location etc inside the Karte enum so that everything must always be qualified (Karte.Location, Karte.App etc.)

@kiliankoe
Copy link
Owner

I like the idea of moving the questionable named types into Karte, even though that is a bit more verbose when using them, it's closer to how it should be if the namespace weren't overridden. Thanks for the suggestion! 👍

@kiliankoe
Copy link
Owner

fixed with 8cded89

@kiliankoe
Copy link
Owner

I just pushed version 4.0.0 with your suggested changes, thanks again 😊

@fluidsonic
Copy link
Author

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants