Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJS/ESM, overriddeable Nested Folder character, and update of minimatch #70

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZipBrandon
Copy link

I initially was doing a PR to address #57 but ended up with a few more enhancements to address the direction and evolution of Remix. I'm happy to address any issues or concerns.

  • adds CJS/ESM build
  • adds nestedFolderChar for alternative character for nested folders
  • modifies routeRegex to support either RegExp or (options) => RegExp
  • updates minimatch to 9.0.0 for parity to @remix-run/remix
  • adds tests for enhancements.

- adds `nestedFolderChar` for alternative character for nested folders
- modifies `routeRegex` to support either RegExp or (options) => RegExp
- updates minimatch to 9.0.0 for parity to @remix-run/remix
- adds tests for enhancements.
@ld-kyee
Copy link

ld-kyee commented Nov 3, 2023

Hi, is there any update on when this is going to get merged? I have a similar issue

@ZipBrandon
Copy link
Author

@kiliman Getting this back in your view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants