New configuration to enable debug mode #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tungleduyxyz
force-pushed
the
killbill_admin_ui_issue_330
branch
from
952ab6e
to
5d613af
Compare
tungleduyxyz
force-pushed
the
killbill_admin_ui_issue_330
branch
from
5d613af
to
067fc04
Compare
|
About Rubocop issue, ENV.fetch('ENABLE_DEBUG_MODE') can not work with Java system. |
tungleduyxyz
force-pushed
the
killbill_admin_ui_issue_330
branch
3 times, most recently
from
726e6cf
to
f53ff09
Compare
tungleduyxyz
force-pushed
the
killbill_admin_ui_issue_330
branch
from
f53ff09
to
1a36ae7
Compare
pierre
approved these changes
May 21, 2024
There was a problem hiding this comment.
I'm fine making this configurable.
That being said, to fix killbill/killbill-admin-ui#330, we should do something else (consider_all_requests_local should usually be false in production). I believe config.exceptions_app could help.
See how https://github.com/richpeck/exception_handler does it for instance.
As suggested in killbill/killbill-admin-ui#330 (comment), we could keep the static error page, but add a box below it (maybe collapsed by default) to expand on the error. That way, users can understand the problem even when consider_all_requests_local=false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: killbill/killbill-admin-ui#330