Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate api pojos #54

Closed
sbrossie opened this issue Feb 23, 2022 · 1 comment
Closed

Integrate api pojos #54

sbrossie opened this issue Feb 23, 2022 · 1 comment

Comments

@sbrossie
Copy link
Member

This task consists in leveraging the api-pojo code generation tool to generate all the POJOs associated with our killbill-api interfaces, and check them in as part of this repo.

Then, go through this code and check what existing POJOs we had created by hand and either replace or extend (if there is some business logic) those. Doing a quick inspection, I see the following candidates - to be confirmed:

PluginDryRunArguments
PluginTag
PluginEntitlementSpecifier
PluginPaymentOptions
PluginPlanPhasePriceOverride
PluginCustomField
PluginAccountData
PluginPaymentTransactionInfoPlugin
PluginHostedPaymentPageFormDescriptor
PluginPaymentMethodPlugin
PluginGatewayNotification
PluginPaymentMethodInfoPlugin
PluginCallContext
PluginTenantContext
PluginInvoiceItem
@sbrossie
Copy link
Member Author

This work was done as part of #59 and #61 and is currently in work-for-55 branch until we decide if this goes in master (0.22.x) release or active work-for-release-0.23.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant