Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage plugin framework inside (test) catalog plugin #55

Open
sbrossie opened this issue Feb 25, 2022 · 2 comments
Open

Leverage plugin framework inside (test) catalog plugin #55

sbrossie opened this issue Feb 25, 2022 · 2 comments

Comments

@sbrossie
Copy link
Member

The current repo killbill-catalog-plugin-test is not using this repo as a base.

We should leverage all the new api POJOs (see #54) and stop pulling the classes from the killbill repo, i.e remove this dependency.

However, such dependency is also used to deserialize the XML catalog, by leveraging all the JAXB annotation. Perhaps instead we could use as a source JSON catalog files (see https://killbill.github.io/slate/#catalog-retrieve-the-catalog-as-json to extract such catalog json), and from the json data write a json parser leveraging jackson and the new api POJOs from this repo.

@sbrossie
Copy link
Member Author

Note that we could simplify the catalog plugin:

  1. Remove support for harcdoded large catalog
  2. As a start, check-in a json catalog in the resource, and use this.

@sbrossie
Copy link
Member Author

This work has been done as part of catalog-plugin-test PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant