-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Implementations #9
Comments
Max,
This is correct, the api package only defines interfaces (actually there
are exceptions), and so you would need to implement that interface.
There are obviously implementations on the KB side, but they would force
you to pull jars which we don't suggest you do.
I think you have a point that this is such a common object, everybody (that
writes plugins) will have to end up defining that simple POJO and probably
we should consider adding it in the api package. But also not te common use
case it to create account using JARXS (REST) api for which clients
libraries exist.
Stéphane
…On Thu, Jan 5, 2017 at 8:04 AM, Max Gfeller ***@***.***> wrote:
The createAccount method on the accountUserApi needs a parameter of the
type AccountData for which only the interface is defined. Not sure if i'm
missing something here but i can't find a existing implementation for
AccountData (and also other types) and ended up implementing one myself.
Is there an existing implementation somewhere?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAPEfuaCuoKH-czYkJNROL2IejcZe9VYks5rPRR5gaJpZM4Lb1u3>
.
|
Stéphane, thanks for your answer! Instead of having everyone to implement those interfaces i would vote to have those POJOs provided in the framework. Would love to hear what others think of that. |
We've started implementing POJOs under org.killbill.billing.plugin.api.core. We'll add more as needed (PR welcome too!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
createAccount
method on theaccountUserApi
needs a parameter of the typeAccountData
for which only the interface is defined. Not sure if i'm missing something here but i can't find a existing implementation forAccountData
(and also other types) and ended up implementing one myself.Is there an existing implementation somewhere?
The text was updated successfully, but these errors were encountered: