Add support for SEPA direct debit payment method #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous flow for credit cards which uses Stripe's Payment Intents API (1$ card auth which is later voided) does not work with SEPA direct debit, as SEPA direct debit can only be used with an automatic capture. To keep the overall amount of code as low as possible the credit card flow was also adapted such that there is only one flow for both payment methods. Instead of using the Payment Intents API the plugin now uses Setup Intents, i.e. the payment method is only setup for later payments.
pierre
requested changes
Mar 31, 2021
| return buildAccount(currency, UUID.randomUUID().toString(), UUID.randomUUID().toString(), UUID.randomUUID().toString(), UUID.randomUUID().toString(), UUID.randomUUID().toString().substring(0, 16), country); | ||
| } | ||
|
|
||
| // Currently needed as TestUtils.buildAccount does not create a valid e-mail address |
There was a problem hiding this comment.
FYI Filed killbill/killbill-plugin-framework-java#46 for this.
src/test/java/org/killbill/billing/plugin/stripe/TestStripePaymentPluginApi.java
Outdated
Show resolved
Hide resolved
|
The version number still needs to be updated. I can update the PR when you tell me which number the next release should get. |
|
Thanks! I've released 7.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SEPA direct debit.
The previous flow for credit cards which uses Stripe's Payment Intents API (1$ card auth which is later voided) does not work with SEPA direct debit, as SEPA direct debit can only be used with an automatic capture. To keep the overall amount of code as low as possible the credit card flow was also adapted such that there is only one flow for both payment methods. Instead of using the Payment Intents API the plugin now uses Setup Intents, i.e. the payment method is only setup for later payments.
When this PR is in a state to be merged, we need to change the version number of the plugin.