Skip to content

Commit

Permalink
junction: Fix major typo where recurringBillingMode ends up being null!
Browse files Browse the repository at this point in the history
  • Loading branch information
sbrossie committed Aug 28, 2015
1 parent 441ed79 commit 65d54b9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
Expand Up @@ -45,7 +45,7 @@ public class DefaultBillingEventSet extends TreeSet<BillingEvent> implements Sor


private boolean accountAutoInvoiceOff = false; private boolean accountAutoInvoiceOff = false;
private List<UUID> subscriptionIdsWithAutoInvoiceOff = new ArrayList<UUID>(); private List<UUID> subscriptionIdsWithAutoInvoiceOff = new ArrayList<UUID>();
private BillingMode recurrringBillingMode; private BillingMode recurringBillingMode;


/* (non-Javadoc) /* (non-Javadoc)
* @see org.killbill.billing.junction.plumbing.billing.BillingEventSet#isAccountAutoInvoiceOff() * @see org.killbill.billing.junction.plumbing.billing.BillingEventSet#isAccountAutoInvoiceOff()
Expand All @@ -57,7 +57,7 @@ public boolean isAccountAutoInvoiceOff() {


@Override @Override
public BillingMode getRecurringBillingMode() { public BillingMode getRecurringBillingMode() {
return null; return recurringBillingMode;
} }


/* (non-Javadoc) /* (non-Javadoc)
Expand Down Expand Up @@ -90,12 +90,8 @@ public void setAccountAutoInvoiceIsOff(final boolean accountAutoInvoiceIsOff) {
this.accountAutoInvoiceOff = accountAutoInvoiceIsOff; this.accountAutoInvoiceOff = accountAutoInvoiceIsOff;
} }


public BillingMode getRecurrringBillingMode() { public void setRecurringBillingMode(final BillingMode recurringBillingMode) {
return recurrringBillingMode; this.recurringBillingMode = recurringBillingMode;
}

public void setRecurrringBillingMode(final BillingMode recurrringBillingMode) {
this.recurrringBillingMode = recurrringBillingMode;
} }


@Override @Override
Expand Down
Expand Up @@ -86,7 +86,7 @@ public BillingEventSet getBillingEventsForAccountAndUpdateAccountBCD(final UUID
final List<SubscriptionBaseBundle> bundles = subscriptionApi.getBundlesForAccount(accountId, context); final List<SubscriptionBaseBundle> bundles = subscriptionApi.getBundlesForAccount(accountId, context);
final DefaultBillingEventSet result = new DefaultBillingEventSet(); final DefaultBillingEventSet result = new DefaultBillingEventSet();
final StaticCatalog currentCatalog = catalogService.getCurrentCatalog(context); final StaticCatalog currentCatalog = catalogService.getCurrentCatalog(context);
result.setRecurrringBillingMode(currentCatalog.getRecurringBillingMode()); result.setRecurringBillingMode(currentCatalog.getRecurringBillingMode());


try { try {
final Account account = accountApi.getAccountById(accountId, context); final Account account = accountApi.getAccountById(accountId, context);
Expand Down

0 comments on commit 65d54b9

Please sign in to comment.