Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account invoices pagination API #1272

Closed
pierre opened this issue Feb 5, 2020 · 3 comments
Closed

Account invoices pagination API #1272

pierre opened this issue Feb 5, 2020 · 3 comments
Assignees

Comments

@pierre
Copy link
Member

pierre commented Feb 5, 2020

When accounts have a large number of invoices, the call /1.0/kb/accounts/{accountId}/invoices isn't performant. We should expose a pagination-like API instead.

@pierre
Copy link
Member Author

pierre commented Feb 5, 2020

The existing call could also be optimized today if we were to return shallow objects (withInvoiceItems=false):

invoiceDaoHelper.populateChildren(invoices, invoicesTags, entitySqlDaoWrapperFactory, context);

@reshmabidikar
Copy link
Contributor

Quick question, do we want to keep the existing endpoint for backward compatibility? Or should the new pagination endpoint replace the existing one?

@reshmabidikar
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants