Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account invoices pagination API #1272

Open
pierre opened this issue Feb 5, 2020 · 1 comment
Open

Account invoices pagination API #1272

pierre opened this issue Feb 5, 2020 · 1 comment
Labels

Comments

@pierre
Copy link
Member

@pierre pierre commented Feb 5, 2020

We accounts have a large number of invoices, the call /1.0/kb/accounts/{accountId}/invoices isn't performant. We should expose a pagination-like API instead.

@pierre pierre added the enhancement label Feb 5, 2020
@pierre

This comment has been minimized.

Copy link
Member Author

@pierre pierre commented Feb 5, 2020

The existing call could also be optimized today if we were to return shallow objects (withInvoiceItems=false):

invoiceDaoHelper.populateChildren(invoices, invoicesTags, entitySqlDaoWrapperFactory, context);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.