Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Spotbugs errors #1853

Closed
xsalefter opened this issue May 10, 2023 · 1 comment · Fixed by #1855
Closed

Address Spotbugs errors #1853

xsalefter opened this issue May 10, 2023 · 1 comment · Fixed by #1855

Comments

@xsalefter
Copy link
Contributor

  1. Enable check.fail-spotbugs in each module (do not in root killbill project, otherwise, it wont build

  2. Find a way to fix the error

  3. If (2) is either:

    • too costly
    • almost impossible to fix
    • it is as is as designed/intended

    then exclude it to <killbill-root-project>/spotbugs-exclude.xml file.

  4. Remove the @SuppressFBWarnings annotations and use spotbugs-excude.xml file instead.

@xsalefter
Copy link
Contributor Author

Fix order:

killbill-api
killbill-util
killbill-tenant       
killbill-account      
killbill-catalog      
killbill-currency     
killbill-subscription 
killbill-entitlement  
killbill-junction     
killbill-usage        
killbill-invoice      
killbill-overdue      
killbill-payment      
killbill-beatrix      
killbill-jaxrs        
killbill-profiles         
killbill-profiles-killbill 
killbill-profiles-killpay 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant