Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added crate-level doc tests to demo single element range behaviour. #18

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Added crate-level doc tests to demo single element range behaviour. #18

merged 1 commit into from
Oct 20, 2018

Conversation

babhishek21
Copy link
Contributor

Fixes #12 .

We should

  • document this behavior (either in the crate-level docs or in the docs for up_to/down_to) and
  • make these unit tests doc tests

I haven't removed the unit tests at the bottom of the file, yet. Let's wait until we've moved to doc tests as much as possible.

@killercup
Copy link
Owner

Thanks!

I haven't removed the unit tests at the bottom of the file, yet. Let's wait until we've moved to doc tests as much as possible.

SGTM

@killercup killercup merged commit b539757 into killercup:master Oct 20, 2018
@killercup killercup mentioned this pull request Oct 20, 2018
Closed
@babhishek21 babhishek21 deleted the crate_doctests branch October 21, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@babhishek21 @killercup