This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
feat: looser bounds on main! return type #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced custom `Result` and `Error` with std types Fixes killercup#31
|
Perfect, thanks! Can you add a quick line to the change log? (Just add a "Changed" section with a list that has this is a single point) |
|
Thanks! |
This was referenced Feb 3, 2018
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
feat: looser bounds on main! return type
How
Replaced custom
ResultandErrorwith std typesTested against the head tutorial in the getting started guide.
Fixes #31