This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Examples and tests #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killercup
force-pushed
the
examples-and-tests
branch
3 times, most recently
from
c8982e5
to
6caca78
Compare
First step towards #63. Instead of `.cargo/config` and recompiling stuff over and over again, we'll be adding sub-crates to `examples/`.
#63 is going according to plan.
This changes the call to waltz to render the code from the guides into the `examples/` directory instead of a some temporary directory and assert that they are checked in. cf. #63
killercup
force-pushed
the
examples-and-tests
branch
from
6caca78
to
fd69780
Compare
|
Memo to self: Add a leading newline when waltz appends to files. (killercup/waltz#15) |
The idea is this: Since the code from the guides is now checked in as crates in `examples/`, we can call `cargo test --all` in the one CI build and only use the waltz build step to assert that they are up to date. While we're at it, let's also turn on caching. cf .#63
killercup
force-pushed
the
examples-and-tests
branch
from
fd69780
to
759696d
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #63