Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable subtitle splitting #392

Closed
YoriJaski opened this issue Mar 23, 2024 · 4 comments
Closed

Option to disable subtitle splitting #392

YoriJaski opened this issue Mar 23, 2024 · 4 comments

Comments

@YoriJaski
Copy link

Please add an option to disable subtitle splitting. Most sentences split, and changing the font size does nothing. This often ends up with incomplete sentences on anki in the sentence field if mining with an external program or extension such as yomitan or yomichan.

Mining using asbplayer keeps the sentence intact, although more inconvenient than having an option to avoid subtitle splitting.

@killergerbah
Copy link
Owner

I think I understand what you mean by subtitles "splitting" (a single sentence being split across two subtitles) but what does that have to do with font size?

To be clear, asbplayer doesn't do anything special to subtitle timing - the subtitles appearing split is a consequence of the subtitle file itself. However, some work could be done to try to intelligently guess when adjacent subtitles comprise a single sentence.

@YoriJaski
Copy link
Author

You're right, It's actually just the subtitle file, asbplayer isn't doing anything to split them. To explain the font size, I thought maybe lowering it would stop it from splitting due to the font being smaller in its container. My bad

@killergerbah
Copy link
Owner

As a workaround for now I would suggest using the side panel to mine multiple lines at once. Clicking dragging and holding will mine multiple subtitles.

@killergerbah
Copy link
Owner

I've made a separate issue for asbplayer to intelligently detect sentences split across subtitles: #396

@killergerbah killergerbah closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants