-
Notifications
You must be signed in to change notification settings - Fork 42
Session Management & text track support #19
base: master
Are you sure you want to change the base?
Conversation
… off after stopping chromecast
small fixes to reload old tech & source, and only start on player.ready, plus applying changes to the actual coffeescript
No need for this to be here as this was a custom param for my solution
Hi! Thank you very much for your changes! I think you've understand something wrong in the project. It is written in CoffeeScript, and will be translated to JavaScript when running You think that you would be able to make the changes in the coffee files? The commits of @PeterMHoward are ok! In the Contribution section of the README you can find out how to get the setup done. |
Yes i can do this when i have some free time :) , obviously as you can tell i just changed the code in the dist folder . |
I would help you out but its very hard to see the changes for me in the git diff because you reformatted the code ! :) Would be awesome. CoffeeScript is quite simple to learn. I'd love to migrate the project to es6, but i don't have time at the moment :( |
Yeah sorry for the reformat was the only way i could get my head around it for the session management comparing it to the google example. All this JS is new to me and i have a long way to go. So i am obviously making rookie mistakes :). I am just going through diffs and the coffee now to point out the changes i should make. |
Previously if you was to join a session you would only get a console log output of this. With the new changes you are able to actually join the session and control it.
Added text track support.