This repository has been archived by the owner on Jan 17, 2020. It is now read-only.
Reflect native controls #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgiuliani
added a commit
that referenced
this pull request
Sep 18, 2014
Reflect native controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request i will handle the events, when the controls in the extension are clicked.
I should get this data in the
ChromecastComponent::onMediaStatusUpdatemethod.This problem was mentioned in the following issue: benjipott/video.js-chromecast#5
Update
I can't find a way to detect if the user has muted the player with the extension. So i will merge this now, and as soon as i find a solution, i will create another pull request.