Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar url broken #1196

Closed
daesters opened this issue Oct 28, 2019 · 4 comments · Fixed by #1201
Closed

Avatar url broken #1196

daesters opened this issue Oct 28, 2019 · 4 comments · Fixed by #1201
Labels
Milestone

Comments

@daesters
Copy link

Describe the bug
The avatar is a nice new feature. The problem is, when kimai is installed as subfolder of the top level domain, e.g example.com/kimai2. Then, avatars won't be shown, because the url will resolve in example.com/avatars/.png instead of example.com/kimai2/avatars/.png

To Reproduce
Steps to reproduce the behavior:

  1. Go to example.com/kimai2/de/admin/user/
  2. You won't see the avatars, only broken images of the users
  3. Right-Click on one of the broken images
  4. You will get to an url, like example.com/avatars/.png
  5. Insert 'kimai2', like example.com/kimai2/avatars/.png
  6. Avatar will show up.

Additional context
Add any other context about the problem here.

  • Kimai version kevinpapst/kimai2 | 1.4.2.0@de533e7031ae194b35f6a638cd95f5c94c516796
  • PHP version 7.3.1
@kevinpapst
Copy link
Member

Hi @daesters , thanks for letting me know!
I have no subdirectory installation, any chance you could test the changes from the PR #1201 ?
I cannot verify if they work properly, all I can say is that they still work as before for me in a root folder installation.

@daesters
Copy link
Author

daesters commented Nov 6, 2019

Hi @kevinpapst
Everything works now with v1.5, PR #1201 fixed the problem.
Thank you very much

@kevinpapst
Copy link
Member

Thanks for your feedback, good to hear!

@lock
Copy link

lock bot commented Jan 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants