Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Allow to set user for timesheet #1259

Merged
merged 4 commits into from
Nov 23, 2019
Merged

API: Allow to set user for timesheet #1259

merged 4 commits into from
Nov 23, 2019

Conversation

kevinpapst
Copy link
Member

Description

Fixes #1252

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #1259 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1259      +/-   ##
============================================
+ Coverage     92.38%   92.39%   +<.01%     
- Complexity     3635     3638       +3     
============================================
  Files           362      362              
  Lines         11221    11225       +4     
============================================
+ Hits          10367    10371       +4     
  Misses          854      854
Impacted Files Coverage Δ Complexity Δ
src/Form/API/TimesheetApiEditForm.php 100% <100%> (ø) 3 <0> (+1) ⬆️
src/Form/TimesheetEditForm.php 86.79% <100%> (ø) 59 <0> (+2) ⬆️
src/API/TimesheetController.php 96.08% <100%> (+0.03%) 69 <0> (ø) ⬇️

@kevinpapst kevinpapst merged commit 641c199 into master Nov 23, 2019
@kevinpapst kevinpapst deleted the timesheet-api-user branch November 23, 2019 13:21
@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timesheet Creation via API
1 participant