Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-excisting page opened, 404 given and page stuck when not applying filter but using page buttons immediately #4279

Closed
3 tasks done
SaturnusDJ opened this issue Sep 7, 2023 · 4 comments
Labels

Comments

@SaturnusDJ
Copy link
Contributor

Describe the issue

Came across this bug for the All items page. It probably applies to all pages with filter and page buttons.

  1. Make sure there are more entries than the current page size. So that page buttons appear at the bottom.
  2. Using the filter, select a project that has less entries than the current page size.
  3. Do not press the search button in the filter window.
  4. Scroll down and select e.g. page 2.
  5. You will get a 404 page, and no way to reset. The only way to get back to normal is log out and log in.

The explanation for this is that apparently when clicking the page button in the bottom, the filter will still get applied, while at the same time page 2 is opened, which actually does not exist.

Searched for 'page', 'filter' and '404' in issues and discussions. No match found.
Linking #4207, #4206 and #4208 for hits on "404".

I already tried

Kimai version

2.0.31

How do you run Kimai?

Docker

Which PHP version are you using?

8.1

Logfile

No response

Screenshots

No response

@SaturnusDJ SaturnusDJ added the bug label Sep 7, 2023
@kevinpapst
Copy link
Member

I saw something similar before ... but no-one ever reported it, so 🤷

Seems now I have to tackle it 😁

@kevinpapst kevinpapst added this to the 2.1 - Stabilizing milestone Sep 7, 2023
kevinpapst added a commit that referenced this issue Sep 7, 2023
@kevinpapst kevinpapst mentioned this issue Sep 7, 2023
6 tasks
kevinpapst added a commit that referenced this issue Sep 7, 2023
* added function to check if meta-field is defined by a plugin
* hide un-defined meta-fields in details view
* fix default charset = utf8mb4
* remove broken DATABASE_VERSION fallback
* split off upgrade infos for version 1.x
* fix page out of range #4279
@SaturnusDJ
Copy link
Contributor Author

😇
Thank you for the patch!!

@kevinpapst
Copy link
Member

Thanks for reporting 👍

Copy link

github-actions bot commented Dec 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants