Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User roles and permission management via Admin UI #1231

Merged
merged 14 commits into from Nov 10, 2019
Merged

Conversation

kevinpapst
Copy link
Member

Description

Added functionality to create new user roles via UI.
Added functionality to change role permission via UI.

No more need to change the local.yaml!

Documentation, see kimai/www.kimai.org#45

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.6 milestone Nov 9, 2019
@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #1231 into master will decrease coverage by <.01%.
The diff coverage is 94.76%.

@@             Coverage Diff              @@
##             master    #1231      +/-   ##
============================================
- Coverage      92.8%   92.79%   -0.01%     
- Complexity     3446     3496      +50     
============================================
  Files           348      355       +7     
  Lines         10641    10786     +145     
============================================
+ Hits           9875    10009     +134     
- Misses          766      777      +11
Impacted Files Coverage Δ Complexity Δ
src/EventSubscriber/DashboardSubscriber.php 100% <ø> (ø) 8 <0> (-1) ⬇️
src/Voter/UserVoter.php 90.62% <ø> (-0.56%) 16 <0> (-1)
src/Controller/CalendarController.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Voter/AbstractVoter.php 85.71% <ø> (ø) 7 <0> (ø) ⬇️
src/Controller/HomepageController.php 80% <ø> (ø) 5 <0> (ø) ⬇️
src/Controller/AbstractController.php 57.14% <ø> (ø) 9 <0> (ø) ⬇️
src/Controller/TimesheetController.php 100% <ø> (ø) 4 <0> (-1) ⬇️
src/Twig/IconExtension.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/DependencyInjection/Configuration.php 97.99% <ø> (-0.01%) 23 <0> (ø)
src/Repository/RolePermissionRepository.php 100% <100%> (ø) 3 <3> (?)
... and 23 more

@kevinpapst kevinpapst merged commit af0f897 into master Nov 10, 2019
@kevinpapst kevinpapst deleted the dynamic-roles branch November 10, 2019 17:54
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant