Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve kimai v1 importer #1543

Merged
merged 1 commit into from Mar 11, 2020
Merged

improve kimai v1 importer #1543

merged 1 commit into from Mar 11, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Mar 11, 2020

Description

improve kimai v1 importer: do not break for projects without customer

Fixes #1539

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Mar 11, 2020
@kevinpapst kevinpapst added this to the 1.9 milestone Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #1543 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1543   +/-   ##
=========================================
  Coverage     92.61%   92.61%           
  Complexity     4359     4359           
=========================================
  Files           422      422           
  Lines         13523    13523           
=========================================
  Hits          12524    12524           
  Misses          999      999           

@kevinpapst kevinpapst merged commit e7458e7 into master Mar 11, 2020
@kevinpapst kevinpapst deleted the improve-importer branch March 11, 2020 23:20
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

setCustomer() must be an instance
1 participant