Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for weekly invoice #1780

Merged
merged 6 commits into from Jun 28, 2020
Merged

Conversation

maarten-k
Copy link
Contributor

Description

Should close invoice: sum calculation on entry per week
#1434

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklistcomposer kimai:code-check

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst
Copy link
Member

Thanks @maarten-k - I will give it a try soon

@maarten-k
Copy link
Contributor Author

Documentation can be found at kimai/www.kimai.org#65

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #1780 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1780   +/-   ##
=========================================
  Coverage     92.30%   92.30%           
- Complexity     4892     4894    +2     
=========================================
  Files           450      451    +1     
  Lines         15136    15142    +6     
=========================================
+ Hits          13971    13977    +6     
  Misses         1165     1165           
Impacted Files Coverage Δ Complexity Δ
src/Invoice/Calculator/WeeklyInvoiceCalculator.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...rc/Invoice/Hydrator/InvoiceItemDefaultHydrator.php 98.73% <100.00%> (+0.03%) 13.00 <0.00> (ø)

@kevinpapst kevinpapst merged commit 8530a03 into kimai:master Jun 28, 2020
@kevinpapst
Copy link
Member

Thank you @maarten-k 👍

@kevinpapst kevinpapst added this to the 1.10 milestone Jun 28, 2020
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants