Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve customer validation #2083

Merged
merged 1 commit into from Nov 1, 2020
Merged

improve customer validation #2083

merged 1 commit into from Nov 1, 2020

Conversation

kevinpapst
Copy link
Member

Description

empty currency lead to invalid API response

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Nov 1, 2020
@kevinpapst kevinpapst added this to the 1.12 milestone Nov 1, 2020
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #2083 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2083   +/-   ##
=========================================
  Coverage     93.28%   93.28%           
- Complexity     5804     5807    +3     
=========================================
  Files           531      531           
  Lines         17571    17571           
=========================================
  Hits          16391    16391           
  Misses         1180     1180           
Impacted Files Coverage Δ Complexity Δ
src/Entity/Customer.php 100.00% <100.00%> (ø) 83.00 <6.00> (+3.00)

@kevinpapst kevinpapst merged commit aba06ba into master Nov 1, 2020
@kevinpapst kevinpapst deleted the fix-validation branch November 1, 2020 23:50
@kevinpapst kevinpapst modified the milestones: 1.12, 1.11.2 Nov 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant