Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not apply rate factor multiple times #2807

Merged
merged 1 commit into from Oct 3, 2021
Merged

Conversation

kevinpapst
Copy link
Member

Description

Fixes #1988

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Oct 3, 2021
@kevinpapst kevinpapst added this to the 1.15.3 milestone Oct 3, 2021
@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #2807 (17062ed) into master (b6430d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2807   +/-   ##
=========================================
  Coverage     92.28%   92.28%           
- Complexity     7582     7584    +2     
=========================================
  Files           674      674           
  Lines         22254    22256    +2     
=========================================
+ Hits          20538    20540    +2     
  Misses         1716     1716           
Impacted Files Coverage Δ
src/Timesheet/RateService.php 98.46% <100.00%> (+0.04%) ⬆️

@kevinpapst kevinpapst merged commit ea415e3 into master Oct 3, 2021
@kevinpapst kevinpapst deleted the skip-rate-factor branch October 3, 2021 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing timesheet record with a rate factor applied, keeps applying the factor with each edit.
1 participant