Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress deprecation notice, convert route param #3391

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Conversation

kevinpapst
Copy link
Member

Description

This will suppress an unfixable deprecation notice on PHP8.1 systems.

A boolean route param was converted to string in the hope that it will fix an issue that occurred on one(?) system.
Hopefully Fixes #3390

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.21 milestone Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #3391 (1449596) into master (665f0d0) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master    #3391   +/-   ##
=========================================
  Coverage     91.89%   91.89%           
  Complexity     7810     7810           
=========================================
  Files           742      742           
  Lines         23599    23600    +1     
=========================================
+ Hits          21687    21688    +1     
  Misses         1912     1912           
Impacted Files Coverage Δ
src/Configuration/StringAccessibleConfigTrait.php 85.93% <0.00%> (ø)
src/Controller/SystemConfigurationController.php 98.01% <100.00%> (+<0.01%) ⬆️

@kevinpapst kevinpapst merged commit cd29715 into master Jun 30, 2022
@kevinpapst kevinpapst deleted the deprecation branch June 30, 2022 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting lockdown period leads to 500 internal server error
1 participant