Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow negative duration via internal API #3573

Merged
merged 3 commits into from Oct 10, 2022
Merged

Conversation

kevinpapst
Copy link
Member

Description

This is NOT about entering negative duration via the UI, but ONLY via the internal API.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.27 milestone Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #3573 (78182de) into master (1959d4d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3573      +/-   ##
============================================
- Coverage     91.74%   91.74%   -0.01%     
+ Complexity     7893     7891       -2     
============================================
  Files           744      744              
  Lines         23806    23805       -1     
============================================
- Hits          21842    21841       -1     
  Misses         1964     1964              
Impacted Files Coverage Δ
src/Entity/Timesheet.php 98.93% <ø> (ø)
src/Utils/LocaleHelper.php 100.00% <ø> (ø)
src/Validator/Constraints/Duration.php 100.00% <ø> (ø)
src/Utils/Duration.php 100.00% <100.00%> (ø)
.../Validator/Constraints/TimesheetBasicValidator.php 95.19% <100.00%> (ø)

@kevinpapst kevinpapst changed the title allow negative duration to be entered via internal API allow negative duration via internal API Oct 10, 2022
@kevinpapst kevinpapst merged commit 0cefcf0 into master Oct 10, 2022
@kevinpapst kevinpapst deleted the negative-duration branch October 10, 2022 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant