Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow PHP 8.3 #4471

Merged
merged 3 commits into from
Dec 1, 2023
Merged

allow PHP 8.3 #4471

merged 3 commits into from
Dec 1, 2023

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Dec 1, 2023

Description

  • Support for using PHP 8.3
  • CI workflow uses 8.2 for code coverage
  • CI workflow uses 8.3 for all tests
  • Allow 8.3 in composer dependency
  • Fix use of range() and auto-width columns for Excel exports

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #4471 (9807f0f) into main (f570b55) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4471   +/-   ##
=========================================
  Coverage     88.28%   88.28%           
  Complexity     8717     8717           
=========================================
  Files           783      783           
  Lines         29168    29168           
=========================================
  Hits          25751    25751           
  Misses         3417     3417           
Files Coverage Δ
src/Export/Base/XlsxRenderer.php 96.77% <100.00%> (ø)
src/Export/Spreadsheet/Writer/XlsxWriter.php 92.85% <100.00%> (ø)

@kevinpapst kevinpapst added this to the 3.0 - Planned features milestone Dec 1, 2023
@kevinpapst kevinpapst merged commit e0769bc into main Dec 1, 2023
5 checks passed
@kevinpapst kevinpapst deleted the php-8.3 branch December 1, 2023 21:40
@kevinpapst kevinpapst removed this from the Planned features milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant