Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML user service #4748

Merged
merged 5 commits into from Apr 5, 2024
Merged

SAML user service #4748

merged 5 commits into from Apr 5, 2024

Conversation

kevinpapst
Copy link
Member

Description

Refactor SamlProvider to use UserService instead of Repository directly

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@kevinpapst kevinpapst added this to the 2.14.0 milestone Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 88.19%. Comparing base (b6c98f8) to head (024a8be).

❗ Current head 024a8be differs from pull request most recent head 0921735. Consider uploading reports for the commit 0921735 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4748      +/-   ##
============================================
+ Coverage     88.16%   88.19%   +0.02%     
- Complexity     8878     8879       +1     
============================================
  Files           789      789              
  Lines         29130    29129       -1     
============================================
+ Hits          25683    25689       +6     
+ Misses         3447     3440       -7     
Files Coverage Δ
src/Command/ActivateUserCommand.php 100.00% <100.00%> (ø)
src/Command/CreateUserCommand.php 95.12% <100.00%> (ø)
src/Command/DeactivateUserCommand.php 100.00% <100.00%> (ø)
src/Command/DemoteUserCommand.php 100.00% <100.00%> (ø)
src/Command/PromoteUserCommand.php 100.00% <100.00%> (ø)
...Controller/Security/SelfRegistrationController.php 93.82% <100.00%> (ø)
src/User/UserService.php 88.00% <100.00%> (+0.67%) ⬆️
...rc/Controller/Security/PasswordResetController.php 82.89% <50.00%> (ø)
src/Controller/ProfileController.php 92.62% <50.00%> (ø)
src/Controller/WizardController.php 58.10% <33.33%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@kevinpapst kevinpapst marked this pull request as ready for review April 5, 2024 16:57
@kevinpapst kevinpapst merged commit dd51c8d into main Apr 5, 2024
4 checks passed
@kevinpapst kevinpapst deleted the saml-user-service branch April 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant