Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.18 #4878

Merged
merged 23 commits into from
Jun 16, 2024
Merged

Release 2.18 #4878

merged 23 commits into from
Jun 16, 2024

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented May 24, 2024

Description

  • only trigger api_access voter if API call was triggered from outside UI
  • move weekly-hours screen outside of card
  • added API method to fetch color configuration
  • revert API request matcher
  • store user via service instead of repository directly when called via API
  • changed CSRF error wording
  • added some new translations
  • fixes Space in mobile view too big #4898 - Space in mobile view too big
  • fixes The Create Activity form contain extra fields #4897 - The Create Activity form contain extra fields
  • unify color handling in tomselect
  • unify tag color management
  • fixed: tags found by ID when using numbers as names

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@kevinpapst kevinpapst added feature request API release a new minor version - PR will not be included in release notes labels May 24, 2024
@kevinpapst kevinpapst added this to the 2.18 milestone May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (e29ef25) to head (bee61a1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4878      +/-   ##
============================================
+ Coverage     87.75%   87.78%   +0.03%     
- Complexity     8975     8985      +10     
============================================
  Files           797      797              
  Lines         29431    29448      +17     
============================================
+ Hits          25828    25852      +24     
+ Misses         3603     3596       -7     
Files Coverage Δ
src/API/Authentication/ApiRequestMatcher.php 100.00% <100.00%> (ø)
src/API/ConfigurationController.php 100.00% <100.00%> (ø)
src/API/TagController.php 96.96% <100.00%> (+0.96%) ⬆️
src/API/UserController.php 87.17% <100.00%> (+0.51%) ⬆️
src/Command/UserLoginLinkCommand.php 12.90% <ø> (ø)
src/Controller/ActivityController.php 92.12% <100.00%> (+0.06%) ⬆️
src/Entity/Tag.php 100.00% <100.00%> (ø)
src/Entity/User.php 90.16% <ø> (+0.04%) ⬆️
...rm/DataTransformer/TagArrayToStringTransformer.php 93.93% <100.00%> (+1.08%) ⬆️
src/Form/Type/ColorChoiceType.php 97.05% <100.00%> (+4.90%) ⬆️
... and 7 more

... and 5 files with indirect coverage changes

@kevinpapst kevinpapst marked this pull request as ready for review June 16, 2024 11:11
@kevinpapst kevinpapst merged commit 987b46b into main Jun 16, 2024
6 checks passed
@kevinpapst kevinpapst deleted the release-2.18 branch June 16, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API feature request release a new minor version - PR will not be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space in mobile view too big The Create Activity form contain extra fields
1 participant