Load export type ids dynamically

[simone-gasparini]

Description

Load export type ids dynamically

Fixes #702

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have executed bin/console kimai:phpcs --fix to make sure my changes adopt the correct code style
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I agree that this code is used in Kimai and will be published under the MIT license

[kevinpapst]

Fixing a test by deleting it is the worst possible solution. Can you please try to find tests for the new logic and check if you can fix the old one.

[simone-gasparini]

I've restored the old test and added a foreach to add types. For the new implementation i think that the existing test it's already ok.
https://github.com/kevinpapst/kimai2/blob/master/tests/Controller/ExportControllerTest.php#L59

[kevinpapst]

I am not completely happy with this method being in the controller.
Maybe it could be moved as factory function to the ServiceExport. Registering the Query as a service could work as well and then registering the renderer type in a compiler pass.

I'll give it another thought and maybe push a change later on.

[kevinpapst]

I decided to remove the type validation from the query object, as it doesn't belong there.
And there was already another check in place in the controller... will merge now.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.