Update users nickname

kimchanhyung98 · Apr 2, 2024 · c71adba · c71adba
1 parent d20fb58
commit c71adba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/Http/Controllers/Account/SignUpController.php b/app/Http/Controllers/Account/SignUpController.php
@@ -19,21 +19,20 @@ class SignUpController extends Controller
      */
     public function __invoke(SignUpRequest $request)
     {
-        DB::beginTransaction();
         try {
+            DB::beginTransaction();
             $user = User::firstOrCreate([
                 'email' => $request->email,
             ], [
                 'name' => $request->name,
-                'nickname' => $request->nickname ?? $request->name,
+                'nickname' => $request->nickname,
                 'password' => Hash::make($request->password),
             ]);
 
             if (! $user->wasRecentlyCreated) {
                 abort(409, 'already exists');
             }
             // $user->sendEmailVerificationNotification();
-
             DB::commit();
         } catch (Exception $e) {
             DB::rollBack();

diff --git a/app/Http/Requests/Account/SignUpRequest.php b/app/Http/Requests/Account/SignUpRequest.php
@@ -11,7 +11,7 @@ public function rules(): array
         return [
             'email' => ['required', 'email', 'unique:users,email', 'max:100'],
             'name' => ['required', 'string', 'max:50'],
-            'nickname' => ['nullable', 'string', 'max:50'],
+            'nickname' => ['required', 'string', 'unique:users,nickname', 'max:50'],
             'password' => ['required', 'string', 'min:8', 'max:100'],
         ];
     }

diff --git a/app/Models/User.php b/app/Models/User.php
@@ -19,6 +19,7 @@ class User extends Authenticatable
      */
     protected $fillable = [
         'name',
+        'nickname',
         'email',
         'password',
     ];